-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the cedar data ingest #2472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, just two minor comments
|
||
|
||
# repository links | ||
REPOSITORY_STUDY_ID_LINK_TEMPLATE = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better if we move this constant def to the top of the file
.get("serial_num", None) | ||
) | ||
except Exception: | ||
print(f"Unable to get serial number for study") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also print this if serial_num == None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jira Ticket: HP-1343
New Features
Updates to the heal cedar ingestion script
added logic for
heal_platform_citation
,repository_study_link
,repository_citation
, andrelated studies