Automation for Gen3 Discovery AI Service #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rstore data instead of configmap
2 tasks
emalinowski
reviewed
Nov 28, 2023
| metadata: | ||
| name: gen3-discovery-ai-service | ||
| annotations: | ||
| getambassador.io/config: | |
There was a problem hiding this comment.
Unless you know what this is for, I don't think we need this annotation. Im assuming this was added when we were thinking about fully switching to ambassador from revproxy, but I don't think thats happening now, so we can probably remove this.
There was a problem hiding this comment.
Noted, I copy and pasted from a different service to start with, this must've been there. I'll remove it
emalinowski
approved these changes
Mar 4, 2024
|
Bypassing branch protections for the failing jenkins tests (since these have seemingly been broken for a while). We assume little risk with merging this since the new service is fairly isolated from other services |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes