Feat/vhdc prod workflows scaleup #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments. Now, it checks if they exist in the cluster-autoscaler deployment, and only adds them if they don't have them.
jawadqur
reviewed
Apr 17, 2023
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Will this script be overriden by gitops job in any way? 🤔
There was a problem hiding this comment.
We're good! I double-checked the script, and it doesn't touch the autoscaler. I also double-checked, and we do have gitops-sync running in perf, so we would have seen issues.
jawadqur
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to add changes we made in vhdcperf, so they can be deployed in vhdcprod. This covers only the Argo Helm chart and cluster-autoscaler changes, as the Opencost changes have not been finalized. (We want to come to a final decision on sizing for the pods and nodes, and run a smoke test to validate that the setup can survive a very high number of nodes in the clsuter).