Feat/argo workflow metrics #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xport metrics to Datadog
…eus metrics that Datadog can scrape. For now, we're going to leave this as a separate branch while we figure out the cost-benefit on exporting these metrics, and if it makes sense to do this by default.
…into feat/argoWorkflowMetrics
…ed by the Argo workflow controller.
…/cloud-automation into feat/argoWorkflowMetrics
…nexpectedly upgrade an Argo workflows deployment
…/cloud-automation into feat/argoWorkflowMetrics
emalinowski
reviewed
Feb 20, 2023
| @@ -243,7 +243,7 @@ if [[ "$ctxNamespace" == "default" || "$ctxNamespace" == "null" ]]; then | |||
|
|
|||
| helm repo add argo https://argoproj.github.io/argo-helm --force-update 2> >(grep -v 'This is insecure' >&2) | |||
| helm repo update 2> >(grep -v 'This is insecure' >&2) | |||
| helm upgrade --install argo argo/argo-workflows -n argo -f ${valuesFile} | |||
| helm upgrade --install argo argo/argo-workflows -n argo -f ${valuesFile} --version 0.22.11 | |||
There was a problem hiding this comment.
It would be nice if we could set that as the default but allow it to be overwritten, similar to this.
jawadqur
reviewed
Feb 20, 2023
| @@ -243,7 +243,7 @@ if [[ "$ctxNamespace" == "default" || "$ctxNamespace" == "null" ]]; then | |||
|
|
|||
| helm repo add argo https://argoproj.github.io/argo-helm --force-update 2> >(grep -v 'This is insecure' >&2) | |||
| helm repo update 2> >(grep -v 'This is insecure' >&2) | |||
| helm upgrade --install argo argo/argo-workflows -n argo -f ${valuesFile} | |||
| helm upgrade --install argo argo/argo-workflows -n argo -f ${valuesFile} --version 0.22.11 | |||
There was a problem hiding this comment.
So instead of harcoding this version, let's try to read from manifest, with this version as a default.
See karpenter script
jawadqur
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-xxxx
New Features
Breaking Changes
Bug Fixes
Added annotations to the Argo workflow controller pod to enable Datadog to read metrics from it.
Improvements
Dependency updates
Deployment changes