Add FIPS enabled AMI to TF #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jawadqur
commented
Mar 17, 2022
- Add FIPS enabled AMI to TF
- Add SSM policy to workers iam role
emalinowski
previously approved these changes
Mar 17, 2022
emalinowski
previously approved these changes
Mar 21, 2022
emalinowski
reviewed
Mar 21, 2022
tf_files/aws/modules/eks/cloud.tf
Outdated
| # Needed if we need to bring up custom AMI's that have been encrypted using a kms key | ||
| resource "aws_iam_service_linked_role" "autoscaling" { | ||
| aws_service_name = "autoscaling.amazonaws.com" | ||
| custom_suffix = "ASG" |
There was a problem hiding this comment.
If there are multiple commons the arn will match for each and lead to tf errors. We should change this to something either random or specific to the common, so that there is not an overlap. Easiest solution is probably ${var.vpc_name}.
There was a problem hiding this comment.
You are 100% correct. Thanks for updating the PR! 🙌
…unique per commons
emalinowski
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.