Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(fix-it-fridays): Speeding up k8s reset #1599

Merged
merged 9 commits into from
Jul 20, 2021
Merged

Conversation

themarcelor
Copy link
Contributor

Quick experiment

@@ -79,15 +79,15 @@ fi

if g3k_manifest_lookup .versions.fence 2> /dev/null; then
# data ecosystem sub-commons may not deploy fence ...
gen3 kube-setup-fence
gen3 kube-setup-fence &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It it safe to fork some of these setup jobs? I think some apps like fence assume that the audit service ran first to set up the SQS queue, and if things run out of order an app could start with missing resources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. There must be inter-dependencies between the apps...
Perhaps the Kubernetes ReadinessProbe should ping the /status endpoint and the status check should make sure the other micro-service is up and running -- then the services could be self-aware and we wouldn't need to orchestrate that at the cloud-automation / infra provisioning stage.

else
gen3_log_info "not deploying portal - no manifest entry for .versions.portal"
fi

gen3_log_info "enable network policy"
gen3 kube-setup-networkpolicy "enable" || true
gen3 kube-setup-networkpolicy "enable" || true &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may actually want...

Suggested change
gen3 kube-setup-networkpolicy "enable" || true &
{gen3 kube-setup-networkpolicy "enable" || true} &

...if I'm understanding this right. Otherwise I think the first command will block.

Copy link
Contributor Author

@themarcelor themarcelor Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc'ing the original authors:
@m0nhawk @jawadqur

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no response here.
@williamhaley , do you want to push a commit with your suggestion?

@themarcelor themarcelor merged commit 645bd99 into master Jul 20, 2021
@themarcelor themarcelor deleted the fix/k8s-reset-stuff branch July 20, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants