Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Update detect-secrets precommit #8072

Merged
merged 1 commit into from
Nov 8, 2024
Merged

-Update detect-secrets precommit #8072

merged 1 commit into from
Nov 8, 2024

Conversation

BedfordWest
Copy link
Contributor

-Add new study announcements to the NIAID homepage

Link to Jira ticket if there is one:

Environments

accessclinicaldata.niaid.nih.gov

Description of changes

  • Updates the detect-secrets pre-commit hook.
  • Updates the secrets baseline since the hook is incorrectly detecting the NIAID homepage update as a secret and it's in json so can't be ignored
  • Adds two new study announcements to the NIAID home page

@BedfordWest
-Update detect-secrets precommit
f4f3144 
-Add new study announcements to the NIAID homepage
@BedfordWest BedfordWest requested review from frankliuao and a team as code owners November 7, 2024 16:10
MaribelleHGomez
MaribelleHGomez approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BedfordWest BedfordWest merged commit 9e11747 into master Nov 8, 2024
3 checks passed
@BedfordWest BedfordWest deleted the chore/niaid-home-new-studies branch November 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaribelleHGomez MaribelleHGomez MaribelleHGomez approved these changes

@CTDS-Fortel CTDS-Fortel CTDS-Fortel approved these changes

@haraprasadj haraprasadj Awaiting requested review from haraprasadj

@frankliuao frankliuao Awaiting requested review from frankliuao frankliuao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BedfordWest @MaribelleHGomez @CTDS-Fortel