Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brhstaging documentation update 082522 #5037

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

DanBiber
Copy link
Contributor

Link to Jira ticket if there is one:

Environments

Description of changes

Copy link
Contributor

@aartivnkt aartivnkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm still some old changes showing up here: 1) "In order to link the account to the involved repositories, navigate to the [Workspace Page]", that was changed to Profile page in your other PR, but seeing workspace here? 2) STATA stuff was also removed in the other PR right, I see it here. 3) In this line "Users can download data files associated with a study by leveraging the CTDS-owned python software development kit (SDK) and the tool “Gen3-client” if the file size exceeds 250 MB" could you remove Gen3-client? Also in this section "a) Download Data Files in Workspaces using the Python SDK", it shows PLACEHOLDER.txt stuff which is old stuff

@aartivnkt aartivnkt self-requested a review August 26, 2022 13:41
Copy link
Contributor

@aartivnkt aartivnkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making these changes!

@aartivnkt aartivnkt merged commit c6a1caf into master Aug 26, 2022
@aartivnkt aartivnkt deleted the brhstaging-documentation-update-082522 branch August 26, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants