Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In memory google cache fix #4811

Merged
merged 2 commits into from
Jun 29, 2022
Merged

In memory google cache fix #4811

merged 2 commits into from
Jun 29, 2022

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Jun 28, 2022

Link to Jira ticket if there is one:

Environments

Description of changes

  • Fix fence in memory google presigned url

@BinamB BinamB requested review from trevars and a team as code owners June 28, 2022 20:04
@PlanXCyborg
Copy link
Contributor

nci-crdc-staging.datacommons.io/manifest.json

Deployment changes

Breaking changes

  • fence
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore(jupyter-nde1.1.0) #988 (Feat/passport fence#964)

@PlanXCyborg
Copy link
Contributor

nci-crdc-staging.datacommons.io/manifest.json

Deployment changes

Breaking changes

  • fence
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore(jupyter-nde1.1.0) #988 (Feat/passport fence#964)

@atharvar28 atharvar28 merged commit a0b51f1 into master Jun 29, 2022
@atharvar28 atharvar28 deleted the chore/in_mem_fix branch June 29, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants