OAuthClient_to_OAuth2Client #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exist) with OAuth2Client (new name)
| @@ -1,4 +1,4 @@ | |||
| from authlib.client import OAuthClient | |||
| from authlib.oauth2.client import OAuth2Client | |||
There was a problem hiding this comment.
thanks for the contribution 🙂 how did you run into this issue? the current code seems to be working fine in our services
There was a problem hiding this comment.
chicagopcdc/amanuensis imports authutils and authlib. I was attempting to upgrade to newer releases and encountered the error because 'OAuthClient' doesn't exist in more recent releases of authlib. I checked 0.15.3 and 0.15.5 specifically.
|
Hey @dvenckusuchgo, thank you for the catch and fix! I created PR #60 to add a unit test and maintain backwards compatibility for code that imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description about what this pull request does.
Please make sure to follow the DEV guidelines before asking for review.
New Features
Breaking Changes
Bug Fixes
Replace references to OAuthClient (doesn't exist) with OAuth2Client (new name)
Improvements
Dependency updates
Deployment changes