fix: Prevents creating an unexpected user #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/etc/cloud/cloud.cfg` sets the default user "ubuntu" for any instance of the Ubuntu distro. Changing that is outside of our scope, as it would affect other platforms. Instead we override that key with nothing to prevent creating any user at all unless explicitely specified by user-data. Fixes: ubuntu/WSL#468
The redundant "distro" subkey is necessary in order to match exactly what is in `/etc/cloud/cloud.cfg`, omitting it would result in the default user still being created as this would be a "generic" `system_info` while the one in `/etc/cloud/cloud.cfg` would be the Ubuntu specific.
didrocks
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/cloud/cloud.cfgsets the default user "ubuntu" for any instance of the Ubuntu distro. Changing that is outside of our scope, as it would affect other platforms.Instead we override that key with nothing to prevent creating any default user at all. User creation must be explicitely specified by user-data.
Starting an instance without this change (you'll see the "ubuntu" account UID 1000):
Starting an instance with this change already seeded (o UID 1000 in /etc/passwd, /home is empty):
Fixes: ubuntu/WSL#468
Closes: UDENG-2748