chore: Move ratings client to monorepo #1505
Conversation
| @@ -0,0 +1,22 @@ | |||
| name: app_center_ratings_client | |||
There was a problem hiding this comment.
I see you renamed the main dart file to ratings_client.dart . Should we not then update the name in the pubspec.yaml to reflect that?
There was a problem hiding this comment.
The ratings_client.dart is only a barrel file, so once it is imported it will say something like:
import 'package:app_center_ratings_client/ratings_client.dart';instead of the slightly over-kill:
import 'package:app_center_ratings_client/app_center_ratings_client.dart';We could rename the whole package, but maybe it is good to state in the name what the ratings are for?
There was a problem hiding this comment.
Oh, it is actually not a barrel file only, but same same.
The class in there is called RatingsClient, so then the file should be called that (apparently we haven't turned on that lint rule). :)
There was a problem hiding this comment.
It probably should be a barrel file though, I'll update the PR to that.
There was a problem hiding this comment.
Haha, we're back to app_center_ratings_client.dart, because otherwise it will have the same name as the now new src/ratings_client.dart. Good talk. 😂
There was a problem hiding this comment.
Haha, I feel left out now 😂
There was a problem hiding this comment.
I have it in the back of my head I renamed it to match the name in the pubspec because of a rule re: uploading to pub.dev? I could be mistaken
…orepo chore: Move ratings client to monorepo
No description provided.