Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev rewrite v1.0.16 debug and tutorial #558

Merged
merged 6 commits into from
Sep 2, 2021
Merged

Dev rewrite v1.0.16 debug and tutorial #558

merged 6 commits into from
Sep 2, 2021

Conversation

wangzhishi
Copy link
Contributor

@wangzhishi wangzhishi commented Sep 1, 2021 •
edited
Loading

  • update grid_search_orbit
  • apply the orbit style decorator to timeseriessplitter.plot as well
  • add unit test for grid search
  • update the remaining four tutorials for the v1.1.0
    • backtest.ipynb
    • build_your_own_model.ipynb
    • model_diagnostics.ipynb
    • utilities_simulation.ipynb

fixes #554
fixes #556

@edwinnglabs
Copy link
Collaborator

#559 is fixing the build_your_own_model.ipynb

edwinnglabs
edwinnglabs approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@edwinnglabs edwinnglabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinnglabs edwinnglabs merged commit 76aa468 into dev-rewrite-v1.0.16 Sep 2, 2021
@edwinnglabs edwinnglabs deleted the dev-rewrite-v1.0.16-debug-and-tutorial branch September 2, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinnglabs edwinnglabs edwinnglabs approved these changes

@vincewu51 vincewu51 Awaiting requested review from vincewu51

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangzhishi @edwinnglabs