Dev rewrite v1.0.16 fix #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wangzhishi
commented
Aug 18, 2021
- fix unit tests for dlt
- fix some unadopted changes in ktrx model
edwinnglabs
reviewed
Aug 19, 2021
| @@ -520,11 +520,11 @@ def _set_knots_scale_matrix(self, df, training_meta): | |||
|
|
|||
| # adjust knot scale with the multiplier derive by the average value and shift by 0.001 to avoid zeros in | |||
| # scale parameters | |||
| global_med = np.expand_dims(np.mean(np.fabs(self._positive_regressor_matrix), axis=0), -1) | |||
| test_flag = local_val < 0.01 * global_med | |||
| global_mean = np.expand_dims(np.mean(np.fabs(self._positive_regressor_matrix), axis=0), -1) | |||
There was a problem hiding this comment.
@wangzhishi is this the same way we are doing in dev branch?
edwinnglabs
reviewed
Aug 19, 2021
| @@ -559,10 +559,10 @@ def _set_knots_scale_matrix(self, df, training_meta): | |||
|
|
|||
| # adjust knot scale with the multiplier derive by the average value and shift by 0.001 to avoid zeros in | |||
| # scale parameters | |||
| global_med = np.expand_dims(np.median(np.fabs(self._regular_regressor_matrix), axis=0), -1) | |||
| test_flag = local_val < 0.01 * global_med | |||
| global_mean = np.expand_dims(np.mean(np.fabs(self._regular_regressor_matrix), axis=0), -1) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.