Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean and standardize example notebooks #462

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Clean and standardize example notebooks #462

merged 2 commits into from
Jul 13, 2021

Conversation

Okroshiashvili
Copy link
Contributor

Description

Clean and standardize example notebooks. Update them to be compatible with the latest version of Orbit. Fix some typos as well.

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Okroshiashvili
Copy link
Contributor Author

Okroshiashvili commented Jul 12, 2021 •
edited
Loading

Hey @edwinnglabs and @wangzhishi . I followed the contribution guide but I was not able to push the commit due to access denial. Then, I forked the repo and send PR that way. If this is not the correct way, please tell me how to do it in the correct way.

Please, review my PR :)

Update:

I tried to clone repo with SSH and then tried to send PR again but still got the ERROR: Permission to uber/orbit.git denied to Okroshiashvili. fatal: Could not read from remote repository.

@wangzhishi
Copy link
Contributor

Hey @edwinnglabs and @wangzhishi . I followed the contribution guide but I was not able to push the commit due to access denial. Then, I forked the repo and send PR that way. If this is not the correct way, please tell me how to do it in the correct way.

Please, review my PR :)

Update:

I tried to clone repo with SSH and then tried to send PR again but still got the ERROR: Permission to uber/orbit.git denied to Okroshiashvili. fatal: Could not read from remote repository.

Hi @Okroshiashvili , it is good to send the PR from a forked repo. You updates look good to me. The only thing is that the output is sort of length when fitting a Stan model. Maybe it is because you used the Conda environment. I refreshed the notebooks, and also fixed some newly spotted bugs. Now the PR is good to merge to the dev branch.

Thanks again, and welcome to be a contributor of orbit.

wangzhishi
wangzhishi approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzhishi wangzhishi merged commit df9613a into uber:dev Jul 13, 2021
@Okroshiashvili
Copy link
Contributor Author

Thanks, @wangzhishi for your comment and help. I'll consider it definitely. Moreover, I spotted some bugs as well and will work to fix them. But, until that, I want to fix #439

wangzhishi added a commit that referenced this pull request Jul 14, 2021
@Okroshiashvili @wangzhishi
Clean and standardize example notebooks (#462)
0878ff2 
* Clean and standardize example notebooks. Update them to be compatible to the latest version of Orbit. Fix typos.

* refresh notebook runs

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzhishi wangzhishi wangzhishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Okroshiashvili @CLAassistant @wangzhishi