Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple prediction percentiles #263

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Add support for multiple prediction percentiles #263

merged 2 commits into from
Oct 30, 2020

Conversation

edwinnglabs
Copy link
Collaborator

@edwinnglabs edwinnglabs commented Oct 30, 2020 •
edited
Loading

Description

Support multiple prediction percentiles. Fixes #261 should also close #250

  • Unit test
  • New feature

tested cases when prediction_percentiles = [5, 10, 95] and = None

@edwinnglabs edwinnglabs added new idea / feature request New feature or request review needed need someone to review labels Oct 30, 2020
@edwinnglabs edwinnglabs self-assigned this Oct 30, 2020
@steveyang90
Copy link
Collaborator

LGTM!

@edwinnglabs edwinnglabs merged commit 31dba6e into master Oct 30, 2020
@edwinnglabs edwinnglabs deleted the multi-pred-percentile branch October 30, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveyang90 steveyang90 steveyang90 approved these changes

Assignees

@edwinnglabs edwinnglabs

Labels
new idea / feature request New feature or request review needed need someone to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request support of multiple prediction percentiles of DLT/LGT
2 participants
@edwinnglabs @steveyang90