Handle case null in switch statements #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
commented
Dec 18, 2024
| @@ -207,7 +207,7 @@ public void cfNullableArrayField() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void supportSwitchExpression() { | |||
| public void switchOnNullable() { | |||
There was a problem hiding this comment.
Rename to clarify what is being tested; this test was written before Java added switch expressions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
=========================================
Coverage 88.11% 88.11%
- Complexity 2205 2206 +1
=========================================
Files 84 84
Lines 7175 7175
Branches 1423 1423
=========================================
Hits 6322 6322
Misses 430 430
Partials 423 423 ☔ View full report in Codecov by Sentry. |
stefanheule
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java 21+, when a
switchstatement containscase null, the expression being switched on is allowed to benull.Fixes #930