Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Check both ReadDesitnation and CreateConsumerGroup permissions when creating consumer group #219

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

hiboyang
Copy link
Contributor

@hiboyang hiboyang commented Jun 9, 2017

No description provided.

@hiboyang hiboyang requested review from thuningxu and datoug June 9, 2017 18:51
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 68.062% when pulling 52900dd on security10 into d67f58e on master.

return fmt.Sprintf(resourceURNTemplateReadDestination, strings.ToLower(deploymentName), strings.ToLower(dstPathString))
}

// GetResourceURNCreateConsumerGroup returns the resource URN to create consumer group, e.g. urn:cherami:dst:zone1_prod:/dst1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cg

err = h.checkAuth(ctx, authResource, common.OperationRead, lclLg)
if err != nil {
return nil, err
}

// Check auth for create destination
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create consumer group

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 68.146% when pulling 23987ee on security10 into d67f58e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 68.175% when pulling 23987ee on security10 into d67f58e on master.

@hiboyang hiboyang merged commit b7cadd7 into master Jun 9, 2017
@hiboyang hiboyang deleted the security10 branch June 9, 2017 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants