This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Fix path-regex to allow for number only strings #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,13 +127,13 @@ func (r *resolverImpl) cachePut(key string, value string) { | |||
| // so names like /./. aren't valid | |||
|
|
|||
| // PathRegex regex for destination path | |||
| var PathRegex = regexp.MustCompile(`^/[\w.]*[a-zA-Z][\w.]*/[\w.]*[a-zA-Z][\w.]*$`) | |||
| var PathRegex = regexp.MustCompile(`^/[\w.]*[[:alnum:]][\w.]*/[\w.]*[[:alnum:]][\w.]*$`) | |||
There was a problem hiding this comment.
Do you have pure numeric path components? /w already allows a-z, A-Z, 0-9, including the _ (underscore), so it seems like you can have a bunch of numbers as long as you have at least one letter with the current system.
There was a problem hiding this comment.
Yes, the canary uses a 'shortened' UUID for the second part of the component .. and that sometimes results in a purely numeric string in the second component of the path -- which would fail to match the original regex (that expects at least one non-numeric character in each component of the path).
thuningxu
approved these changes
Jun 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal canaries use a shortened-uuid to in the latter part of the path to create destinations/CGs. Occasionally, when this results in a pure numeric string, the create destination/cg fails .. because our regular expressions that validate paths seem to (incorrectly?) enforce there is at least one 'alphabetic' character in each part of the path -- while our comment seems to indicate that we are only trying to enforce each part has at least one non-symbolic character.