This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
add pause/resume APIs to publisher and consumer #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiboyang
reviewed
May 23, 2017
| } else { | ||
| // This is a potentially a transient error. | ||
| // Retry on next reconfigure | ||
| return |
There was a problem hiding this comment.
Is it possible here getting infinite loop with high cpu usage if c.paused is zero and error is not EntityNotExistsError?
hiboyang
reviewed
May 23, 2017
| consumerOptions := &cherami.ReadConsumerGroupHostsResult_{} | ||
| if atomic.LoadUint32(&c.paused) == 0 { | ||
| consumerOptions, err = c.client.ReadConsumerGroupHosts(c.path, c.consumerGroupName) | ||
| if err != nil { |
There was a problem hiding this comment.
Just curious, how we pause consuming here when c.paused is zero? It seems it will continue executing when error is nil.
hiboyang
approved these changes
May 23, 2017
abhinav
reviewed
May 25, 2017
| // For non-streaming publishers, Pause/Resume APIs are no-op. | ||
| Pause() | ||
| // Resume publishing. | ||
| Resume() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds pause/resume APIs to publisher and consumer. When paused, we'll just return an empty list of input/output hosts in the reconfiguration thread.