Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minigames are broken #132

Closed
rmcreyes opened this issue Apr 4, 2020 · 0 comments · Fixed by #133
Closed

Minigames are broken #132

rmcreyes opened this issue Apr 4, 2020 · 0 comments · Fixed by #133
Assignees
Labels
bug Something isn't working dev type type type
Milestone

Comments

@rmcreyes
Copy link
Collaborator

rmcreyes commented Apr 4, 2020

Describe the bug
Minigames don't play.

Root Cause
Based on the logs, it seems the unity component is not getting a proper path to the minigame artifacts, and also seems like the unity component is trying to return something too early (before the player makes the choice to start the minigame), so this bug is probably caused by a recent change to GamePlayConsole.tsx:
image

To Reproduce
This will reproduce both locally and on GH Pages.

Expected behavior
A clear and concise description of what you expected to happen.
The game should run, and the unity component should not load until the player makes the choice to start it.

@rmcreyes rmcreyes added bug Something isn't working dev type type type labels Apr 4, 2020
@rmcreyes rmcreyes added this to the Term 2 milestone Apr 4, 2020
@rmcreyes rmcreyes self-assigned this Apr 4, 2020
eloisepeng added a commit that referenced this issue Apr 9, 2020
…on-minigame-events

Fix events responsible for loading minigames in events.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev type type type
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant