Fix issues with the group sync with "Replace" strategy #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsook
approved these changes
Feb 6, 2018
1138241 to
d170d4f
Compare
|
@kitsook good call. I added in a check for that and it lets the user know they need to change their Canvas groups to have unique names before being able to sync (disables sync meanwhile). |
…an merge" flag - Update both import and export logic and also do some refactoring - For import, ensure Canvas group is seen as empty if it contains only ineligible members (i.e. members not in iPeer) - For import, fix an issue with merging the imported non-empty groups with imported empty groups - For export, if update flag is on, delete all the groups in canvas right away to allow users that are in other groups to be exported (if in only 1 iPeer group) - For export, check group memberships when exporting each group (mainly code refactoring) - Fix an issue when sync was not working as expected when group names are numeric - Improve error messages
d170d4f to
6389d84
Compare
|
@xcompass this is ready to be merged in. Feel free to either merge it in or let me know if you'd like me to make any other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with the group sync when choosing "Replace group rather than merge" flag
Closes: #556