Add chrome-sandbox to the Linux x86_64 release workflow #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uazo
reviewed
May 21, 2024
| @@ -397,7 +397,7 @@ jobs: | |||
| gn args out/lin64/ --list >out/lin64/gn_list | |||
| echo "::endgroup::" | |||
|
|
|||
| ninja -C out/lin64 chrome | |||
| ninja -C out/lin64 chrome chrome_sandbox | |||
uazo
reviewed
May 21, 2024
| @@ -162,6 +162,7 @@ jobs: | |||
| echo "::group::-------- linux x64" | |||
| mkdir chrome-lin/ | |||
| cp $OUTPUTFILE_LIN/chrome chrome-lin/ | |||
| cp $OUTPUTFILE_LIN/chrome_sandbox chrome-lin/chrome-sandbox | |||
There was a problem hiding this comment.
could you answer me first at #1053 ?
|
Not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the "chrome-sandbox" to the Linux x86_64 build and release workflows in preparation for the Linux Flatpak.
This will build the 320.7 kB binary which allows Chromium-based browsers to run properly in a sandbox (like Flatpak) on Linux.
All submissions
Format
Subject: Alternative cache (NIK-based)->Alternative-cache-NIK-based.patch)