-
Notifications
You must be signed in to change notification settings - Fork 31
ci(travis): run commitlint on travis ci #581
ci(travis): run commitlint on travis ci #581
Conversation
It appears that this has a merge conflict now. Can you update @ChristianMurphy? Thanks |
Absolutely! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic
@vertein resynced with |
🤔 it looks like the shell script is having issues with the commit ranges in merge commits /cc @marionebl |
@ChristianMurphy I am not entirely sure which
Could you add some debug output
|
remove pre-commit hook that verifies commit message locally. most recent local commit can still be checked with `npm run lint-commit`. Travis CI now checks all commits in a feature branch to ensure they meet the formatting guidelines.
a2d93b3
to
5eaf73a
Compare
welp, after I rebased it works, will add tracing in when/if it breaks again. |
removes
precommit
hook that verifies commit message locally.Combined with #580 this removes all error level commit hooks.
Most recent local commit can still be checked with
npm run lint-commit
.Travis CI now checks all commits in a feature branch to ensure they meet the formatting guidelines.
📓 I still see this as a step backward, checking if a commit message meets the conventional commit standard locally is a lot easier than rewriting history later.
part 2 of #535
part 1 is in #580
Contributor License Agreement adherence: