Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

ci(travis): run commitlint on travis ci #581

Merged

Conversation

ChristianMurphy
Copy link
Contributor

removes precommit hook that verifies commit message locally.
Combined with #580 this removes all error level commit hooks.

Most recent local commit can still be checked with npm run lint-commit.

Travis CI now checks all commits in a feature branch to ensure they meet the formatting guidelines.

📓 I still see this as a step backward, checking if a commit message meets the conventional commit standard locally is a lot easier than rewriting history later.

part 2 of #535
part 1 is in #580


Contributor License Agreement adherence:

@vertein
Copy link
Contributor

vertein commented Oct 18, 2017

It appears that this has a merge conflict now. Can you update @ChristianMurphy?

Thanks

@ChristianMurphy
Copy link
Contributor Author

Absolutely!
Before that it would be nice to get sign off from @davidmsibley, since this PR was made based off his request.

Copy link
Contributor

@davidmsibley davidmsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic

@ChristianMurphy
Copy link
Contributor Author

@vertein resynced with master branch and conflicts resolved

@ChristianMurphy
Copy link
Contributor Author

🤔 it looks like the shell script is having issues with the commit ranges in merge commits
https://travis-ci.org/uPortal-Project/uportal-app-framework/jobs/289541275#L831-L846
It looks like it may be designed to be used with git rebase or git pull --rebase.

/cc @marionebl

@marionebl
Copy link

@ChristianMurphy I am not entirely sure which commitlint call is tripping up here.

  • The logs contain some successful read/lint operations: 820 - 829
  • Then commitlint it is fed with --from=c8571a40341b41123d473af172cc269d381b4cdf, which appears to be invalid according to git-raw-commits

Could you add some debug output

  • before each commitlint call, stating if it is the "triggering commit" or "range" linting
  • the exact $FROM and $TO values used

remove pre-commit hook that verifies commit message locally.
most recent local commit can still be checked with `npm run
lint-commit`.
Travis CI now checks all commits in a feature branch to ensure they meet
the formatting guidelines.
@ChristianMurphy
Copy link
Contributor Author

welp, after I rebased it works, will add tracing in when/if it breaks again.

@ChristianMurphy ChristianMurphy merged commit 89fd2fb into uPortal-Attic:master Nov 1, 2017
@ChristianMurphy ChristianMurphy deleted the ci/commit-lint branch November 1, 2017 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants