Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestAnimationFrame-if and prefixed parameter #981

Closed
slavaleleka opened this issue Apr 7, 2020 · 4 comments
Closed

requestAnimationFrame-if and prefixed parameter #981

slavaleleka opened this issue Apr 7, 2020 · 4 comments
Labels
fixed issue has been addressed

Comments

@slavaleleka
Copy link

logic of requestAnimationFrame-if and no-setInterval-if are different —
prefix ! is needed for mathing in first case and NOT matching in second

for what reason it has been done? and is there any chance to make a behaviour of the prefix ! equal for raf-if.js, nosiif.js/nostif.js?

(as for me, it's better to use ! for not matching)

@uBlock-user uBlock-user added the something to address something to address label Apr 7, 2020
@gorhill
Copy link
Member

gorhill commented Apr 7, 2020

I should change requestAnimationFrame-if to match no-setInterval-if, if I remember correctly, no-setInterval-if was changed because most case require the blacklist approach, but requestAnimationFrame-if was not revisited.

I can't find instance of requestAnimationFrame-if in uBO's lists, so it should be a safe change.

@uBlock-user
Copy link
Contributor

There's one filter in uBO Annoyances list for bloomberg.com

@slavaleleka
Copy link
Author

slavaleleka commented Apr 9, 2020

@gorhill so are you going to revise it soon? or not soon?

@gorhill
Copy link
Member

gorhill commented Apr 9, 2020

For sure for next release, but I need to think of how to make the change while keeping compatibility for the currently used version since it turns out it's being used after all.

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 15, 2020
Related issue:
- uBlockOrigin/uBlock-issues#981

To be consistent with no-setTimeout-if.js.

requestAnimationFrame-if.js is deprecated and must no longer be
used, it will be removed in the near future when it's no longer
in use in default filter lists.

no-requestAnimationFrame-if.js is aliased to norafif.js.
@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Apr 15, 2020
JustOff pushed a commit to gorhill/uBlock-for-firefox-legacy that referenced this issue Jun 20, 2020
Related issue:
- uBlockOrigin/uBlock-issues#981

To be consistent with no-setTimeout-if.js.

requestAnimationFrame-if.js is deprecated and must no longer be
used, it will be removed in the near future when it's no longer
in use in default filter lists.

no-requestAnimationFrame-if.js is aliased to norafif.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants