Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension icon doesn't revert back when the domain is removed from Whitelist tab #680

Closed
uBlock-user opened this issue Jul 21, 2019 · 1 comment
Labels
bug Something isn't working Chromium specific to Chromium/Chrome fixed issue has been addressed

Comments

@uBlock-user
Copy link
Contributor

uBlock-user commented Jul 21, 2019

Description

Disabling uBO on a website and enabling it back by removing the domain from Whitelist tab doesn't change the extension icon on Chromium.

A specific URL where the issue occurs

https://www.google.com/

Steps to Reproduce

  1. Browse to https://www.google.com/

  2. Open the popup panel and click the big blue power button to deactivate uBO on www.google.com, open the dashboard, browse to whitelist, remove the domain entry - www.google.com and Apply changes, close the dashboard tab and switch back to google.com tab.

  3. Open the popup panel and notice the big blue power button is back to being blue as expected, but the extension icon still remains grey and not changing to red.

Expected behavior:

Extension icon should revert back to red when uBO is enabled on google.com after being disabled.

Actual behavior:

Extension icon remains grey.

Your environment

  • uBlock Origin version: 1.21.3b0
  • Browser Name and version: Chromium 77
  • Operating System and version: Win 10

As discussed in https://github.com/orgs/uBlockOrigin/teams/ublock-issues-volunteers/discussions/114

@uBlock-user uBlock-user added bug Something isn't working Chromium specific to Chromium/Chrome labels Jul 21, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 21, 2019
Related issue:
- uBlockOrigin/uBlock-issues#680

Opportunistically, vAPI.tabs has been refactored toward
ES6 syntax.
@uBlock-user uBlock-user added the fixed issue has been addressed label Jul 21, 2019
@uBlock-user
Copy link
Contributor Author

uBlock-user commented Jul 25, 2019

It doesn't work if I open dashboard in a new window instead of new tab, I remember you once mentioning about each new window being isolated from the main browser window, so is that to be expected ?

@Imna1975 Imna1975 mentioned this issue Sep 3, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Chromium specific to Chromium/Chrome fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

1 participant