Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead code in assets.js and trailing whitespaces in scriptlets.js #679

Closed
jspenguin2017 opened this issue Jul 21, 2019 · 1 comment
Closed

Dead code in assets.js and trailing whitespaces in scriptlets.js #679

jspenguin2017 opened this issue Jul 21, 2019 · 1 comment
Labels
fixed issue has been addressed

Comments

@jspenguin2017
Copy link

The code here is no longer useful, because the built-in resource is now immutable:
https://github.com/gorhill/uBlock/blob/master/src/js/assets.js#L981

The variable noRemoteResources can also be removed.
@uBlock-user uBlock-user added the something to address something to address label Jul 21, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 21, 2019
@gorhill
Remove obsolete ublock-resources-related code
4834789 
Related issue:
- uBlockOrigin/uBlock-issues#679
@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Jul 21, 2019
@jspenguin2017 jspenguin2017 changed the title Dead code in assets.js Dead code in assets.js and trailing whitespaces in scriptlets.js Jul 21, 2019
@jspenguin2017
Copy link
Author

@gorhill Another minor issue, trailing whitespace on these lines:
https://github.com/gorhill/uBlock/blob/master/assets/resources/scriptlets.js#L118
https://github.com/gorhill/uBlock/blob/master/assets/resources/scriptlets.js#L710

@jspenguin2017 jspenguin2017 reopened this Jul 21, 2019
@uBlock-user uBlock-user added something to address something to address and removed fixed issue has been addressed labels Jul 21, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 22, 2019
@gorhill
Remove trailing spaces
a89aad0 
Related issue:
- uBlockOrigin/uBlock-issues#679
@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jspenguin2017 @uBlock-user