Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled filter lists in releases are not timestamped #2358

Closed
6 tasks done
benrg opened this issue Nov 10, 2022 · 5 comments
Closed
6 tasks done

Bundled filter lists in releases are not timestamped #2358

benrg opened this issue Nov 10, 2022 · 5 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@benrg
Copy link

benrg commented Nov 10, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

URL(s) where the issue occurs

N/A

Describe the issue

The filter lists in uBlock0_1.45.0.chromium.zip and uBlock0_1.45.0.firefox.signed.xpi all contain

! Last modified: %timestamp%

instead of an actual timestamp. Affected files are:

assets/thirdparties/easylist-downloads.adblockplus.org/easylist.txt
assets/thirdparties/easylist-downloads.adblockplus.org/easyprivacy.txt
assets/ublock/badware.txt
assets/ublock/filters-2020.txt
assets/ublock/filters-2021.txt
assets/ublock/filters-2022.txt
assets/ublock/filters.txt
assets/ublock/lan-block.txt
assets/ublock/legacy.txt
assets/ublock/privacy.txt
assets/ublock/quick-fixes.txt
assets/ublock/resource-abuse.txt
assets/ublock/ubol-filters.txt
assets/ublock/unbreak.txt

easylist.txt and easyprivacy.txt were correctly timestamped in earlier releases. The others have contained ! Last modified: %timestamp% since 1.42, and before that they had no Last modified: line at all.

Screenshot(s)

No response

uBlock Origin version

1.45.0

Browser name and version

N/A

Settings

N/A

Notes

No response

@mapx- mapx- transferred this issue from uBlockOrigin/uAssets Nov 10, 2022
@gwarser gwarser added the bug Something isn't working label Nov 11, 2022
@dportvine
Copy link

I don't have this problem.
Gif

@gwarser
Copy link

gwarser commented Nov 11, 2022

@dportvine extract them from zip or try just after installation. Yours already updated.

@dportvine
Copy link

@dportvine extract them from zip or try just after installation. Yours already updated.

But without updating how to see the date? I didn't pay attention before.

@gorhill
Copy link
Member

gorhill commented Nov 13, 2022

I need to pull the stamped files from gh-pages. So there needs to be two submodules for the same repo, but different branches. I am not familiar with submodules, if somebody can help with this that would be nice.

@gwarser
Copy link

gwarser commented Nov 13, 2022

Or just patch the timestamp?

gorhill added a commit to gorhill/uBlock that referenced this issue Nov 14, 2022
Related issue:
- uBlockOrigin/uBlock-issues#2358

We need two different branches of uAssets to properly add the
default filter lists into the packages. I couldn't figure out
how to do this with submodules, using simple `git clone` as a
dependency just work.
@gorhill gorhill closed this as completed Nov 19, 2022
@gwarser gwarser added the fixed issue has been addressed label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants