Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ati-smarttag and google-ima3 redirect resources #2158

Closed
8 tasks done
Yuki2718 opened this issue Jun 28, 2022 · 12 comments
Closed
8 tasks done

Add ati-smarttag and google-ima3 redirect resources #2158

Yuki2718 opened this issue Jun 28, 2022 · 12 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@Yuki2718
Copy link

Yuki2718 commented Jun 28, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

AG implementation:
https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-redirects.md#ati-smarttag
https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-redirects.md#google-ima3

They often cause problems and exception have been made each time. If the redirect resources work without problem, maybe we can generally redirect and reduce the freuqency of those problems. Even if not, at least we can reduce exposure to these services by domain-specific redirect rules with $important.

A specific URL where the issue occurs

https://www.rte.ie/news/business/2022/0626/1306958-one-third-of-households-just-making-ends-meet/

Steps to Reproduce

  1. For ati-smarttag visit the URL, see embedded player is working with default setting thx to exception.
  2. If you add ||tag.aticdn.net/$script,domain=rte.ie,important, the player will be broken.
  3. If you visit the URL with AG, you'll see working player without exception (as I added the rule in AdguardTeam/AdguardFilters@cb87af8)

Expected behavior

NA

Actual behavior

Exception is often made for these two.

uBlock Origin version

1.43.1b3

Browser name and version

Firefox 101.0.1

Operating System and version

Windows 10

@gwarser gwarser added the enhancement New feature or request label Jun 28, 2022
@krystian3w
Copy link

krystian3w commented Jun 28, 2022

Duplicate of topic from hidden volunteer github team ~6 months ago?

@Yuki2718
Copy link
Author

Yuki2718 commented Jun 30, 2022

Example for ima3: AdguardTeam/AdguardFilters#123100 apparently doesn't work currently
Non-working case: http://yahoo-jp.portal.connectedgamestore.com/game?gameId=0704-nimble_fish

@krystian3w
Copy link

krystian3w commented Jun 30, 2022

I see typo: , mayb we also we should link topic form volunteer "chat".

@gorhill
Copy link
Member

gorhill commented Sep 11, 2022

Firefox has a shim for ima3: https://searchfox.org/mozilla-central/source/browser/extensions/webcompat/shims/google-ima.js#6.

I should just borrow it I guess. It would be nice to have these shims exposed to any API so that extensions can use them.

I need to evaluate if MPLv2 is compatible with GPLv3. Answer, yes

@krystian3w
Copy link

@mozilla fyi!

@gorhill
Copy link
Member

gorhill commented Sep 11, 2022

I can't use Mozilla's version as is it turns out because it uses JS syntax (private properties) that is valid starting with Chromium 74/Firefox 90 -- so I will have to modify to avoid relying on this private field syntax.

Additionally, I used this test case where I recently excepted ima3 to bypass anti-blocker to validate that it works:

  • Navigate to https://www.novelgames.com/en/saliclawsolitaire/
  • Point and click to create a dynamic block rule for imasdk.googleapis.com to override the exception filter
  • Reload the tab
  • Click play button

Without shim, anti-blocker message.

Add filter (need priority to win against the existing redirect in uBO's lists):

||imasdk.googleapis.com/js/sdkloader/ima3.js$3p,redirect-rule=google-ima.js:1

Reload and click play button: still an anti-blocker message. There is a missing event in Firefox's version, and when I add this missing event, the shim works.

gorhill added a commit to gorhill/uBlock that referenced this issue Sep 11, 2022
gorhill added a commit to gorhill/uBlock that referenced this issue Sep 11, 2022
Related issue:
- uBlockOrigin/uBlock-issues#2158

Additionally, added firing of CONTENT_RESUME_REQUESTED event in
start() method.
@gorhill
Copy link
Member

gorhill commented Sep 11, 2022

@wisniewskit

For your interest, I had to add the event CONTENT_RESUME_REQUESTED in start() to unbreak the case detailed above.

@wisniewskit
Copy link

@gorhill, thanks for letting me know, and sorry for the extra porting work!

gorhill added a commit to uBlockOrigin/uAssets that referenced this issue Sep 11, 2022
piquark6046 added a commit to List-KR/List-KR that referenced this issue Sep 18, 2022
google-ima3 redirect resource in uBlock Origin will be available with 1.44.3 or later version.
uBlockOrigin/uBlock-issues#2158
@Yuki2718
Copy link
Author

Yuki2718 commented Jul 4, 2023

Steps to reproduce (or steps to just watch video) is very tedious, but in easylist/easylist#16535 I found redirecting causes pausing video not to work. Was there any similar problem?

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jul 4, 2023

Steps to reproduce (or steps to just watch video) is very tedious, but in easylist/easylist#16535 I found redirecting causes pausing video not to work. Was there any similar problem?

Yes, redirecting google-ima sometimes still cause breakages. Looks like each site can have slightly different coding with it. Some other discussions here: #2265


Does your console throw any errors related to it?

@Yuki2718
Copy link
Author

Yuki2718 commented Jul 4, 2023

Does your console throw any errors related to it?

I don't see anything related to imasdk.

@uBlock-user uBlock-user added the fixed issue has been addressed label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

7 participants