-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ati-smarttag and google-ima3 redirect resources #2158
Comments
Duplicate of topic from hidden volunteer github team ~6 months ago? |
Example for ima3: |
|
Firefox has a shim for ima3: https://searchfox.org/mozilla-central/source/browser/extensions/webcompat/shims/google-ima.js#6. I should just borrow it I guess. It would be nice to have these shims exposed to any API so that extensions can use them. I need to evaluate if MPLv2 is compatible with GPLv3. Answer, yes |
@mozilla fyi! |
I can't use Mozilla's version as is it turns out because it uses JS syntax (private properties) that is valid starting with Chromium 74/Firefox 90 -- so I will have to modify to avoid relying on this private field syntax. Additionally, I used this test case where I recently excepted ima3 to bypass anti-blocker to validate that it works:
Without shim, anti-blocker message. Add filter (need priority to win against the existing redirect in uBO's lists):
Reload and click play button: still an anti-blocker message. There is a missing event in Firefox's version, and when I add this missing event, the shim works. |
Related issue: - uBlockOrigin/uBlock-issues#2158 Additionally, added firing of CONTENT_RESUME_REQUESTED event in start() method.
For your interest, I had to add the event |
@gorhill, thanks for letting me know, and sorry for the extra porting work! |
Related issue: - uBlockOrigin/uBlock-issues#2158
google-ima3 redirect resource in uBlock Origin will be available with 1.44.3 or later version. uBlockOrigin/uBlock-issues#2158
Steps to reproduce (or steps to just watch video) is very tedious, but in easylist/easylist#16535 I found redirecting causes pausing video not to work. Was there any similar problem? |
Yes, redirecting google-ima sometimes still cause breakages. Looks like each site can have slightly different coding with it. Some other discussions here: #2265 Does your console throw any errors related to it? |
I don't see anything related to imasdk. |
Prerequisites
I tried to reproduce the issue when...
Description
AG implementation:
https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-redirects.md#ati-smarttag
https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-redirects.md#google-ima3
They often cause problems and exception have been made each time. If the redirect resources work without problem, maybe we can generally redirect and reduce the freuqency of those problems. Even if not, at least we can reduce exposure to these services by domain-specific redirect rules with
$important
.A specific URL where the issue occurs
https://www.rte.ie/news/business/2022/0626/1306958-one-third-of-households-just-making-ends-meet/
Steps to Reproduce
||tag.aticdn.net/$script,domain=rte.ie,important
, the player will be broken.Expected behavior
NA
Actual behavior
Exception is often made for these two.
uBlock Origin version
1.43.1b3
Browser name and version
Firefox 101.0.1
Operating System and version
Windows 10
The text was updated successfully, but these errors were encountered: