-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Address of webpage' textbox needs to be readonly or changes to it need to be monitored #1836
Comments
Do not bypass the template. |
To be fair the template is no needed here for me to understand the reported issue. My thinking is it's best to leave it as is and see what happens in the future, someone could want to remove information from the URL without changing the target site itself. For now rather than adding restriction, I prefer to wait-and-see if this causes issues in the future (I expect it will not). |
They can still 'remove' information by highlighting and copying the part they want to 'remove', from a readonly field instead. |
Yes. All this needs road testing before asking for changes based on assumptions. There have been already changes in the template following the unforeseen spamming of issues raised yesterday, and we will keep fine tuning according to how things go rather than according to anyone's assumptions of how they will go. |
I know, my answer was not directed at you, it is directed at whoever reads the thread to clarify how the specific issue opened by @jidanni is being handled. |
That Reference in new issue button is just waiting to be exploited, GitHub didn't think about how it bypasses the templates before implementing it, now anybody can click on it and create a whole new issue based on a "comment" post on any issue. |
All I know is if there is a search box
and the user changes it to
and hits ENTER, then he usually would expect it to search for ... B. |
I see. Somebody is about to take a screenshot to post in a bug report, and wants to remove Seems like a 1/1000 rare case, and the other 999 are my 'I changed A to B but it still searched for A' head-scratchers. So nobody has convinced me. Sorry. |
So, |
Yes, I need to fix this. |
Related issue: - uBlockOrigin/uBlock-issues#1836 The URL to report can now be picked from a list of related URLs in order to allow the reporter to publish edited version of the reported URL. Additionally, the hash, user name, and password which could be present in a reported URL are always removed.
If the user changes what is in the
Address of the web page:
textbox,those changes are ignored when he presses the
Find similar reports
button!E.g., if he changes example.com to example.net, the form will still look for example.com reports!
Same with the Create new issue button.
If not planning to read what the user changed, then at least make that textbox readonly.
Originally posted by @jidanni in #1541 (comment)
The text was updated successfully, but these errors were encountered: