Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After downgrading to 1.32.4, uBO is broken #1480

Closed
uBlock-user opened this issue Jan 31, 2021 · 0 comments
Closed

After downgrading to 1.32.4, uBO is broken #1480

uBlock-user opened this issue Jan 31, 2021 · 0 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@uBlock-user
Copy link
Contributor

Description

As per the title

A specific URL where the issue occurs

moz-extension://74e99578-6a58-4388-8858-0330686faee6/dashboard.html#3p-filters.html

Steps to Reproduce

  • Install the latest dev-build and update all the filter-lists that may need updating

  • Downgrade to v1.32.4 and once the downgrade is complete, open the filterlists pane via dashboard and be greeted with this --

Capture2

extension console --

Capture

Your environment

  • uBlock Origin version: 1.32.4
  • Browser Name and version: Fiefox Nightly
  • Operating System and version: Win 10
@uBlock-user uBlock-user added the bug Something isn't working label Jan 31, 2021
gorhill added a commit to gorhill/uBlock that referenced this issue Jan 31, 2021
Related issue:
- uBlockOrigin/uBlock-issues#1480

Forward compatiblity was broken due to `externalLists`
being converted into an Array from a string, i.e.
downgrading to uBO 1.32.4 was completely breaking uBO.

This commit restores `externalLists` as a string which
is what older versions of uBO expect.

A new property `importedLists` has been created to
hold the imported lists as an array, while
`externalLists` will be kept around for a while until
it is completely removed in some future.
@gorhill gorhill changed the title After downgrading to 1.32.4, filter lists pane is broken After downgrading to 1.32.4, uBO is broken Jan 31, 2021
@uBlock-user uBlock-user added the fixed issue has been addressed label Jan 31, 2021
nikobockerman pushed a commit to nikobockerman/uBlock that referenced this issue Feb 10, 2021
Related issue:
- uBlockOrigin/uBlock-issues#1480

Forward compatiblity was broken due to `externalLists`
being converted into an Array from a string, i.e.
downgrading to uBO 1.32.4 was completely breaking uBO.

This commit restores `externalLists` as a string which
is what older versions of uBO expect.

A new property `importedLists` has been created to
hold the imported lists as an array, while
`externalLists` will be kept around for a while until
it is completely removed in some future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

1 participant