Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to change naming of 1P/3P to avoid confusion with 1p/3p #1362

Closed
ryanbr opened this issue Nov 25, 2020 · 5 comments
Closed

Suggestion to change naming of 1P/3P to avoid confusion with 1p/3p #1362

ryanbr opened this issue Nov 25, 2020 · 5 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@ryanbr
Copy link

ryanbr commented Nov 25, 2020

From this commit; gorhill/uBlock@bde3164

Noticed new filter switches, which I didn't initially pick up that p and P is treated differently.

Just to avoid confusion with currently filter switches, would it better to have different naming for them? Just to avoid potential bugs because someone used P instead of a p or vice-versa.
@pes10k
Copy link

pes10k commented Nov 25, 2020 •
edited
Loading

straw suggestion: 1P -> strict1p , 3P -> strict3p

Having very similar but different looking switches do very similar but different things seems likely to cause unnecessary confusion and error. WDYT?

@uBlock-user uBlock-user transferred this issue from uBlockOrigin/uAssets Nov 25, 2020
@uBlock-user uBlock-user added the enhancement New feature or request label Nov 25, 2020
@gorhill
Copy link
Member

gorhill commented Nov 25, 2020

I don't mind strict1p/strict3p. I just know filter list maintainers in general like abbreviations, so I was trying to find something concise. Another idea I had was 1p!/3p! but in the end wasn't too sure about this.

@mapx-
Copy link
Contributor

mapx- commented Nov 25, 2020

s1p / s3p would be fine

@uBlock-user
Copy link
Contributor

or s1P/s3P will do too..

@ryanbr
Copy link
Author

ryanbr commented Nov 25, 2020

we could do both, short form/long form?

gorhill added a commit to gorhill/uBlock that referenced this issue Nov 26, 2020
@gorhill
Rename 1P/3P tp strict1p/strict3p as suggested
60d5b85 
Related issue:
- uBlockOrigin/uBlock-issues#1362
gorhill added a commit to gorhill/uBlock that referenced this issue Nov 26, 2020
@gorhill
Fix forgotton instances of 1P/3P
80413df 
Related commit:
- 60d5b85

Related issue:
- uBlockOrigin/uBlock-issues#1362
@uBlock-user uBlock-user added the fixed issue has been addressed label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pes10k @gorhill @ryanbr @mapx- @uBlock-user