-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a version of "{{origin}}" that uses the whole URL and not just the domain #1281
Comments
Trivial to fix for the element picker, but the complication with this feature is that the full URL is not available when creating the filter from the logger. I tried to create a filter from the logger in Nano using |
Related issue: - uBlockOrigin/uBlock-issues#1281 New supported placeholder: `{{url}}`, which will be replaced by the full URL of the page for which a filter is created.
|
When searching for last comment to append filter to, Don't know how much this is unexpected. I was confused for a while, because when testing template |
|
Related issue: - uBlockOrigin/uBlock-issues#1281 Related feedback: - uBlockOrigin/uBlock-issues#1281 (comment)
I can generate comment:
with use logger to create filters. |
Prerequisites
Description
https://github.com/gorhill/uBlock/wiki/Advanced-settings#autocommentfiltertemplate shows that there are 3 options for which things that are shown in a comment above entries that are made with the element picker: the date, the time, and the site domain. However, Nano Adblocker also had a 4th option called
{{nanoHref}}
that showed the page's URL; and since I've decided to switch to uBlock Origin on my PC, I'm hoping that feature would be ported upstream to uBO under whichever name.Specifically, for example, if an entry for whatever was created while on
https://www.nrk.no/urix/politisk-kaos-i-kirgisistan-1.15188777
, the proposed function would show:And not:
This would be of significant importance to (and would make work faster and easier for) people who contribute to lists that mandate source pages for all new entries. Nano Placeholder Buster used to be the biggest example, but it would also come in handy for many other lists like EasyList, AdGuard Filters, and just about any other list that require specific URLs in user-submitted issue reports and PRs.
A specific URL where the issue occurs
https://www.nrk.no/urix/politisk-kaos-i-kirgisistan-1.15188777
Steps to Reproduce
{{origin}}
as one of the settings forautocommentfiltertemplate
Expected behavior:
A way to make the auto-comment feature for element-picker entries show the full URL of the page.
Actual behavior:
There are no ways in uBO (that I know of) to make the auto-comment feature for element-picker entries show the full URL of the page.
Your environment
The text was updated successfully, but these errors were encountered: