Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .gitattributes aka hightlighter (Linguist) #14695

Closed
wants to merge 1 commit into from
Closed

Create .gitattributes aka hightlighter (Linguist) #14695

wants to merge 1 commit into from

Conversation

linguist-language=AdBlock
@stephenhawk8054
Copy link
Member

@gorhill Sorry, can you check this?

@MasterKia
Copy link
Member

#14699

@krystian3w krystian3w closed this Sep 6, 2022
@krystian3w krystian3w deleted the patch-1 branch September 6, 2022 08:41
@krystian3w
Copy link
Contributor Author

Closed in favour #14699

@gorhill
Copy link
Member

gorhill commented Sep 6, 2022

Possible see on: https://github.com/ameshkov/VscodeAdblockSyntax/blob/master/test_rules.txt

This filter below is valid in uBO, it will convert to ASCII at compile time:

пример.рф##banner

I think it's fair to let filter list maintainers use readable domain names.

@scripthunter7
Copy link
Contributor

@gorhill Yes - most adblockers use the punycode library (I'm not sure about ABP). The unicode domain is a known issue and will be allowed in the next version.

@krystian3w
Copy link
Contributor Author

@scripthunter7 I detected super long lines lost highlight: https://github.com/FiltersHeroes/PolishAnnoyanceFilters/blob/9a59b9c41cf5cfa8faedf570bd74408985f1a542/PPB/uBO_AG/popupy_suplement.txt#L5

I think uBo have similar long lines.

@scripthunter7
Copy link
Contributor

@krystian3w github-linguist/linguist#6063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants