Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acscourier.net: nuisance #26704

Closed
10 of 11 tasks
ExtRIELICi opened this issue Jan 3, 2025 · 7 comments
Closed
10 of 11 tasks

acscourier.net: nuisance #26704

ExtRIELICi opened this issue Jan 3, 2025 · 7 comments

Comments

@ExtRIELICi
Copy link

ExtRIELICi commented Jan 3, 2025

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.). Comment in the old issue threads even when they are closed or even if you have a different problem.
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin along with other content blockers.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site or browser issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL(s) where the issue occurs.

https://acscourier.net

Description

Whenever you visit the website, a large and intrusive AI chat window pops up, preventing you from quickly entering your tracking code. You have to wait for the chat to open fully before you can close it and proceed with your task without interruption. I attached a screenshot below.

Other extensions used

none

Screenshot(s)

Screenshot(s) image

Configuration

Details
@MasterKia
Copy link
Member

MasterKia commented Jan 3, 2025

@gorhill Not sure why acscourier.net##+js(aost, DOMTokenList.prototype.contains, checkIsOpen) or acscourier.net##+js(aost, DOMTokenList.prototype.contains, /^/) doesn't work for me on Firefox even though with acscourier.net##+js(aost, DOMTokenList.prototype.contains) I get this log:

[www.acscourier.net]stackDepth:10
 get inlineScript:283:1
 checkIsOpen https://cdn.smartrep.gr/sr-acs/acs/sr-acs-prod.js:97:1
 ACSWidget/this.makeTooltip https://cdn.smartrep.gr/sr-acs/acs/sr-acs-prod.js:61:1
 ACSWidget/this.init/tooltipInterval< https://cdn.smartrep.gr/sr-acs/acs/sr-acs-prod.js:42:1
 7277/pe/c</</L[0] https://www.acscourier.net/bundles/SpaScripts?v=euNLhamskchH0hMSujDi7z67MyU48lOv5LRDR36qj2w1:4143:1
 invokeTask https://www.acscourier.net/bundles/SpaScripts?v=euNLhamskchH0hMSujDi7z67MyU48lOv5LRDR36qj2w1:4082:1
 runTask https://www.acscourier.net/bundles/SpaScripts?v=euNLhamskchH0hMSujDi7z67MyU48lOv5LRDR36qj2w1:4082:1
 invokeTask https://www.acscourier.net/bundles/SpaScripts?v=euNLhamskchH0hMSujDi7z67MyU48lOv5LRDR36qj2w1:4082:1
 7277/m/this.invoke< https://www.acscourier.net/bundles/SpaScripts?v=euNLhamskchH0hMSujDi7z67MyU48lOv5LRDR36qj2w1:4082:1
 7277/pe/d/m.args[0] https://www.acscourier.net/bundles/SpaScripts?v=euNLhamskchH0hMSujDi7z67MyU48lOv5LRDR36qj2w1:4143:1

The script:
https://cdn.smartrep.gr/sr-acs/acs/sr-acs-prod.js

acscourier.net##+js(aopr, DOMTokenList.prototype.contains) does work.


Okay nvm, this doesn't work either:

  DOMTokenList.prototype.contains = new Proxy(DOMTokenList.prototype.contains, {
    apply(target, thisArg, args) {
      const error = new Error();
      if (error.stack.includes('checkIsOpen') === true) {
        throw new ReferenceError();
      };
      return Reflect.apply(target, thisArg, args);
    }
  })

@MasterKia
Copy link
Member

MasterKia commented Jan 3, 2025

||cdn.smartrep.gr/sr-acs/acs/sr-acs-prod.js^$script,3p,domain=acscourier.net

@kargig Is this something you would add?

@gorhill
Copy link
Member

gorhill commented Jan 3, 2025

@MasterKia I stepped into the code and the match does occur. However the scriptlet still use old logging approach, I will modify it to use the new approach, i.e. to always report when there is a match, or report both matches/no matches when verbose mode is enabled. Currently, you will see there is a match when you add extra parameters , log, match.

@mapx-
Copy link
Contributor

mapx- commented Jan 4, 2025

@ExtRIELICi report here: https://github.com/kargig/greek-adblockplus-filter/issues

@mapx- mapx- closed this as completed Jan 4, 2025
@kargig
Copy link

kargig commented Jan 4, 2025

fwiw from my tests I could type the tracking code in the acs website without closing the AI assistant chat

I'd also be skeptical in adding more filters that remove such annoyances in the "main" Greek ad blocking filter list as these are not really ads. I could create a separate list with Greek annoyances but I'm not sure how many people would subscribe to a second Greek list either.

Do you happen to know how other regional lists handle such requests ?

@MasterKia
Copy link
Member

Yeah I'm not sure about blocking the chat widget either, maybe I could find a filter other than aopr to prevent it from auto-opening.

@krystian3w
Copy link
Contributor

krystian3w commented Jan 18, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants