MakoTV (False Positive)

[IsraeliUser]

https://www.mako.co.il/mako-vod?partner=NavBar
(You need EasyList Hebrew)

Please remove mako.co.il from:
101greatgoals.com,allthetests.com,ancient-origins.net,biology-online.org,calcalist.co.il,convert-me.com,diffen.com,eurweb.com,globes.co.il,grammarist.com,jerusalemonline.com,mako.co.il,nysun.com,reshet.tv,roadracerunner.com,textsfromlastnight.com,trifind.com,walla.co.il,x17online.com,yad2.co.il,ynet.co.il,yocore.com##script:inject(abort-on-property-write.js, upManager)
and add:
mako.co.il##script:inject(nowebrtc.js)

Thanks

[mapx-]

Which is the issue ?

[IsraeliUser]

I get a blank page on Firefox.

[okiehsch]

What does the filter mako.co.il##script:inject(nowebrtc.js) achieve?

I will remove mako.co.il##script:inject(abort-on-property-write.js, upManager).

[IsraeliUser]

They use WebRTC to serve ads.
There are commercials before the videos.

[IsraeliUser]

Same issue (blank page) with mako.co.il##script:inject(nowebrtc.js), and sometimes ads slip through (outside MakoTV).

Please readd mako.co.il to:
101greatgoals.com,allthetests.com,ancient-origins.net,biology-online.org,calcalist.co.il,convert-me.com,diffen.com,eurweb.com,globes.co.il,grammarist.com,jerusalemonline.com,nysun.com,reshet.tv,roadracerunner.com,textsfromlastnight.com,trifind.com,walla.co.il,x17online.com,yad2.co.il,ynet.co.il,yocore.com##script:inject(abort-on-property-write.js, upManager)
and remove:
mako.co.il##script:inject(nowebrtc.js)
until we find a better solution.

Thanks

[IsraeliUser]

Do you have any idea how to fix it? MakoTV works fine on Chrome. But I get a blank page on Firefox.
Please open this issue.

[gorhill]

Ok, I added a hidden setting to control whether scriptlets are injected through stream filtering or not, and the page renders fine if scriptlets are injected as with Chrome (though late), but it does not work if they are injected using stream filtering. I have no idea why at this point. I will continue investigating.

[gorhill]

Ok I think I know why: the page has a HTML error inside the last noscript tag on the page (<ul> instead of </ul>), and this causes the following script tags (which are responsible for the page loading properly) to end up being inside the noscript tag after serializing back the document. End result: the needed script tags at the end are not being seen by Firefox.

[gorhill]

For now I am going to push an update which causes scriptlets to be injected the "slow" way -- just as before, and just as is done in Chromium. There is no obvious way to work around the issue here which is caused by an HTML error in the page: the DOMParser object used internally by uBO does not ignore noscript tags as opposed to the browser internal parser, and I have no way to force DOMParser to ignore noscript tags. So for now I need to roll back scriptlet injection through stream filtering. This will also address other (unrelated) issue gorhill/uBlock#3526.

[gorhill]

This is the part of the DOMParser spec which causes issue here (my emphasis):

script elements get marked unexecutable and the contents of noscript get parsed as markup.

[mapx-]

uBo/ FF issue, closing