Skip to content

Commit

Permalink
update fix #190
Browse files Browse the repository at this point in the history
  • Loading branch information
@okiehsch
okiehsch committed Jan 9, 2017
1 parent 9ea5d68 commit f340633
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion checksums/ublock0.txt
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
56b18eb692248fd0352066c62198c709 assets/ublock/filter-lists.json
cadc15e72055199b194392c3e6814948 assets/ublock/badware.txt
013363b068a39912b2261724b2a66306 assets/ublock/experimental.txt
312a33b17f1a2dd5292638dc9066c4a6 assets/ublock/filters.txt
de260581e679efe8d61de0b2507c301f assets/ublock/filters.txt
fd9c595b155f372080617bc56fa9343f assets/ublock/privacy.txt
f3b91943de7b8662b4e2bdc0d68fc706 assets/ublock/resources.txt
ca1ab39636e516b2c668d7a82b0bd5c9 assets/ublock/unbreak.txt
Expand Down
2 changes: 1 addition & 1 deletion filters/filters.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ nextinpact.com###list_news > section[class]:if(:scope > span:has-text(Publicité
crackberry.com##script:inject(nowebrtc.js)

! https://github.com/uBlockOrigin/uAssets/issues/190#issuecomment-269949614
businessnewsdaily.com,collegehumor.com,dorkly.com,investopedia.com,laptopmag.com,lifeandstylemag.com,phonearena.com,space.com,thepoliticalinsider.com,tomsguide.com##script:inject(nowebrtc.js)
businessnewsdaily.com,collegehumor.com,dorkly.com,investopedia.com,laptopmag.com,lifeandstylemag.com,phonearena.com,space.com,theberry.com,thechive.com,thepoliticalinsider.com,tomsguide.com##script:inject(nowebrtc.js)

! https://github.com/uBlockOrigin/uAssets/issues/244
skidrowreloaded.com##script:inject(popads.net.js)
Expand Down

2 comments on commit f340633

@okiehsch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill
What are your preferences, if there are different ways to fix an issue?
For example #260, the proposed filterset works on my end, what also works is
a simple filter $generichide.
Both solutions fix the Zeus Anti Adblock issue, atleast on my end.

@gorhill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say if generichide works, that would be the preferred way, because

  • it's standard ABP filter syntax (so likely the issue will be solved in EasyList);
  • does not involve creating exception fitlers for 3rd-party network requests to override block filters;
  • and last but not least, using generichide disables the DOM surveyor in uBO's content script, a great gain efficiency-wise.

Please sign in to comment.