Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #315 PHP 8.2 deprecation for dynamic properties #316

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix #315 PHP 8.2 deprecation for dynamic properties #316

merged 2 commits into from
Feb 23, 2023

Conversation

Hikariii
Copy link
Contributor

@Hikariii Hikariii commented Feb 23, 2023 •
edited by u01jmg3
Loading

Fix #315 deprecations for PHP 8.2

@u01jmg3 u01jmg3 self-requested a review February 23, 2023 10:36
@Hikariii Hikariii force-pushed the chore/php82-dynamic-property-deprecated branch from 68ccf1c to 0b3e87b Compare February 23, 2023 10:40
@Hikariii
Copy link
Contributor Author

@u01jmg3 I force-pushed a new commit, because Rector wanted a nice closure: https://github.com/u01jmg3/ics-parser/actions/runs/4251640532/jobs/7394364748#step:9:21

@u01jmg3
Copy link
Owner

u01jmg3 commented Feb 23, 2023

Thanks - will look at this later today. Do I have access to modify this branch if I need to?

@Hikariii
Copy link
Contributor Author

Hikariii commented Feb 23, 2023 •
edited by u01jmg3
Loading

I think you have read-access to all forks.
So checking out my branch and making adjustments should be possible.

@u01jmg3 u01jmg3 changed the title fixes #315 php8.2 deprecations for dynamic properties Fix #315 PHP 8.2 deprecation for dynamic properties Feb 23, 2023
@u01jmg3 u01jmg3 added this to the v2.x.x milestone Feb 23, 2023
@u01jmg3 u01jmg3 merged commit a3a291c into u01jmg3:master Feb 23, 2023
@room34 room34 mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u01jmg3 u01jmg3 u01jmg3 approved these changes

Assignees
No one assigned
Labels
bug-normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICal\Event gives deprecation warnings for PHP 8.2
2 participants
@Hikariii @u01jmg3