Add a test for /api/playlists?contains=:media_id

u-wave · Nov 28, 2024 · de18a81 · de18a81
1 parent 888ef62
commit de18a81
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 1 deletion.
diff --git a/src/controllers/playlists.js b/src/controllers/playlists.js
@@ -64,6 +64,10 @@ async function getPlaylists(req) {
     playlists = await uw.playlists.getUserPlaylists(user);
   }
 
+  playlists.sort((a, b) => {
+    return a.name.localeCompare(b.name);
+  });
+
   return toListResponse(
     playlists.map(serializePlaylist),
     { url: req.fullUrl },

diff --git a/src/plugins/playlists.js b/src/plugins/playlists.js
@@ -503,7 +503,7 @@ class PlaylistsRepository {
 
   /**
    * Get playlists that contain any of the given medias. If multiple medias are in a single
-   * playlist, that playlist will be returned multiple times, keyed on the media's unique ObjectId.
+   * playlist, that playlist will be returned multiple times, keyed on the media ID.
    *
    * @param {MediaID[]} mediaIDs
    * @param {{ author?: UserID }} options

diff --git a/test/playlists.mjs b/test/playlists.mjs
@@ -77,6 +77,46 @@ describe('Playlists', () => {
         sinon.match({ name: 'Playlist B' }),
       ]);
     });
+
+    it('shows all playlists containing a specific media', async () => {
+      const token = await uw.test.createTestSessionToken(user);
+
+      const { playlist: playlistA } = await uw.playlists.createPlaylist(user, { name: 'Playlist A' });
+      const { playlist: playlistB } = await uw.playlists.createPlaylist(user, { name: 'Playlist B' });
+
+      const [onlyA, onlyB, both] = await uw.source('test-source').get(user, ['ONLY_A', 'ONLY_B', 'BOTH']);
+      const a = await uw.playlists.addPlaylistItems(playlistA, [onlyA, both]);
+      const b = await uw.playlists.addPlaylistItems(playlistB, [onlyB, both]);
+
+      const mediaIDOnlyA = a.added[0].media.id;
+      const mediaIDOnlyB = b.added[0].media.id;
+      const mediaIDBoth = a.added[1].media.id;
+
+      const resOnlyA = await supertest(uw.server)
+        .get(`/api/playlists?contains=${mediaIDOnlyA}`)
+        .set('Cookie', `uwsession=${token}`)
+        .expect(200);
+      sinon.assert.match(resOnlyA.body.data, [
+        sinon.match({ name: 'Playlist A' }),
+      ]);
+
+      const resOnlyB = await supertest(uw.server)
+        .get(`/api/playlists?contains=${mediaIDOnlyB}`)
+        .set('Cookie', `uwsession=${token}`)
+        .expect(200);
+      sinon.assert.match(resOnlyB.body.data, [
+        sinon.match({ name: 'Playlist B' }),
+      ]);
+
+      const resBoth = await supertest(uw.server)
+        .get(`/api/playlists?contains=${mediaIDBoth}`)
+        .set('Cookie', `uwsession=${token}`)
+        .expect(200);
+      sinon.assert.match(resBoth.body.data, [
+        sinon.match({ name: 'Playlist A' }),
+        sinon.match({ name: 'Playlist B' }),
+      ]);
+    });
   });
 
   describe('POST /playlists', () => {