Don't escape colons when writing verbatim fields #22
Conversation
src/resolve.rs
Outdated
| '&' | '%' | '$' | '_' if !verb => true, | ||
| ':' if read_char => true, |
There was a problem hiding this comment.
The colon would not be escaped when writing with this condition, even if the field is not to be dumped in verbatim mode. Instead, I suggest the following:
| ':' if read_char => true, | |
| ':' if read_char || !verb => true, |
There was a problem hiding this comment.
Thanks for your suggestion! I added this.
One question: Is there a specific reason for escaping all colons (in non-verbatim mode)? So far, I thought colons are not a problem in bibtex/biblatex files.
However, I found the following issue: JabRef/jabref#5982 If I understand it correctly, colons are only a problem in the bibtex key.
Thanks for your clarification and your help.
There was a problem hiding this comment.
Oops I overlooked your comment. You are right, as far as I see, the colon need not be escaped in values but only in keys. This means that the code would have been right after all, without my suggestion. As we've seen, there is no harm in being permissive about what escapes to accept when reading. If this is no urgent matter I'll revert back to your original PR in the next bugfix release.
There was a problem hiding this comment.
Thanks for your feedback! No, this isn't a urgent matter. 😄
Escape colon also in non-verbatim mode Co-authored-by: Martin Haug <mhaug@live.de>
Also won't escape colon in verbatim outputs (follow up on #22) Bumps version
Also won't escape colon in verbatim outputs (follow up on #22) Bumps version
Hello,
this PR fixes the discussion around colons in #21 .
I'm not sure whether it's smartest way to differentiate between a write and read mode but didn't come up with a better idea so far. Looking forward to your comments!
Best