Don't run Java formatting under JDK 8 #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
commented
Sep 15, 2022
smillst
requested changes
Sep 15, 2022
smillst
previously approved these changes
Sep 15, 2022
|
@smillst Can you look at the CI failures? |
|
I can reproduce this on master with the following command: This seems to be a general problem with the way the spotless plugin works for subprojects. diffplug/spotless#715 is somewhat related. I'm trying to figure out a work around. |
|
The problem is that |
This was referenced Sep 19, 2022
smillst
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the changes in #5325 to this PR to test that they fix the bug exposed by this PR. Merge #5325 first.