fix: error where eager relations in a lazy-loaded entity would be undefined #8564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Given the scenario:
this change intends to fix a bug that happens when lazy-loading a relationship with
await entityA.b
. Alleager
relations from Entity B are not loaded, and are set asundefined
. This happens with allfind
methods and the Query Builder, breaking type-safety, specially for people usingstrictNullChecks
in tsconfig.Fixes #8328 #7841 (comment)
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000