Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build for Native #1180

Merged
merged 8 commits into from
Jun 16, 2022
Merged

Cross-build for Native #1180

merged 8 commits into from
Jun 16, 2022

Conversation

armanbilge
Copy link
Member

No description provided.

@armanbilge
Copy link
Member Author

armanbilge commented Jun 12, 2022

Results on my local:

[error] Failed: Total 3520, Failed 10, Errors 0, Passed 3510, Ignored 2
[error] Failed tests:
[error]         spire.math.PolynomialSamplingScalaCheckSuite
[error]         spire.math.AlgebraicScalaCheckSuite
[error]         spire.math.PolynomialScalaCheckSuite
[error]         spire.math.PolynomialSuite
[error] (testsNative / Test / test) sbt.TestsFailedException: Tests unsuccessful

Also this is kind of outrageous:

  + Factors(n) + Factors(m) = n + m 284.89s
  + Factors(n) - Factors(m) = n - m 223.69s
  + Factors(n) * Factors(m) = n * m 112.69s
  + Factors(n) / Factors(m) = n / m 50.09s
  + Factors(n) % Factors(m) = n % m 113.45s
  + Factors(n) /% Factors(m) = n /% m 134.04s
  + Factors(n).pow(k) = n.pow(k) 59.44s

The same tests on Scala.js:

spire.math.prime.FactorsScalaCheckSuite:
  + Factors(n).value = n 2.02s
  + Factors(n) + Factors(m) = n + m 14.01s
  + Factors(n) - Factors(m) = n - m 12.92s
  + Factors(n) * Factors(m) = n * m 4.76s
  + Factors(n) / Factors(m) = n / m 7.87s
  + Factors(n) % Factors(m) = n % m 6.68s
  + Factors(n) /% Factors(m) = n /% m 8.34s
  + Factors(n).pow(k) = n.pow(k) 1.78s

Edit: Native w/ release-fast + thin:

spire.math.prime.FactorsScalaCheckSuite:
  + Factors(n).value = n 6.59s
  + Factors(n) + Factors(m) = n + m 40.81s
  + Factors(n) - Factors(m) = n - m 60.91s
  + Factors(n) * Factors(m) = n * m 17.29s
  + Factors(n) / Factors(m) = n / m 21.66s
  + Factors(n) % Factors(m) = n % m 24.61s
  + Factors(n) /% Factors(m) = n /% m 25.78s
  + Factors(n).pow(k) = n.pow(k) 13.82s
[info] Passed: Total 8, Failed 0, Errors 0, Passed 8

@armanbilge
Copy link
Member Author

The tl;dr is:

This affects the polynomials which use a regex-based parser.

@armanbilge
Copy link
Member Author

All tests pass locally now. Not sure why CI is failing 😕

@armanbilge armanbilge marked this pull request as ready for review June 16, 2022 21:39
@armanbilge armanbilge merged commit 2ccd1f1 into typelevel:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant