Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying a shorter job name for better display in GHA #761

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

mzuehlke
Copy link
Collaborator

@mzuehlke mzuehlke commented Oct 14, 2024

Before
Bildschirmfoto 2024-10-14 um 16 05 46

After:
Bildschirmfoto 2024-10-14 um 16 06 02

Feedback welcome.
I really dislike this part of the GH UI

@mzuehlke mzuehlke marked this pull request as ready for review October 15, 2024 06:18
@armanbilge
Copy link
Member

I don't have a strong preference ... this is just something we've inherited from sbt-github-actions. My thought is CI refers to the entire workflow (build, test, docs, publish, etc) vs build-and-test is a specific job that is part of CI.

I really dislike this part of the GH UI

Yep, I have struggled many times to figure out which cell of the matrix a failure happened in ...

@valencik
Copy link
Member

This is definitely an improvement in my opinion.
We get to see the Scala version and most of the JVM name.

If we could ditch the -latest suffix from the OS names, that would probably let you see everything of importance.

@mzuehlke
Copy link
Collaborator Author

With the switch from ubuntu-latest to ubuntu-22.04 I am bit reluctant to remove OS version.
"CI" was just my first idea, mostly because it is short 😉
"Test" would be another suggestion (instead of "Build and Test"

@mzuehlke
Copy link
Collaborator Author

Instead of leaving the generation of the job.name to the automation we could generate a name, but only list axes from the matrix that have more than one dimension. In this project that would remove the scala version 8always "2.12" and the project (always "sbt-typelevelJVM").

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's try this :)

@armanbilge armanbilge merged commit 374f8fe into typelevel:main Dec 27, 2024
15 checks passed
@mzuehlke mzuehlke deleted the shorter-job-name branch December 27, 2024 17:56
@bpholt
Copy link
Member

bpholt commented Jan 29, 2025

FWIW, I like the new name, but the change has caused me a fair amount of admin work updating branch protection rules in all the repos where we're using sbt-typelevel. Since we have required status checks in place, no PRs can be merged following this change without an admin manually logging in an updating the rules to reflect the new names. Had I realized this change was coming, I would have 👎 solely due to the amount of downstream work involved.

(I'm also worried about the change from ubuntu-latest to ubuntu-22.04. When that Ubuntu version is bumped, it's going to trigger another round of the same administrative headache. 😩)

If anyone is aware of a way to automate the changes to the required status checks, I would be very grateful!

@mzuehlke
Copy link
Collaborator Author

@bpholt it is probably too late fro that, but an option could be to make this configurable.
Then you could have avoided this tedious admin work 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants