-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying a shorter job name for better display in GHA #761
Conversation
I don't have a strong preference ... this is just something we've inherited from sbt-github-actions. My thought is CI refers to the entire workflow (build, test, docs, publish, etc) vs build-and-test is a specific job that is part of CI.
Yep, I have struggled many times to figure out which cell of the matrix a failure happened in ... |
This is definitely an improvement in my opinion. If we could ditch the |
With the switch from |
# Conflicts: # .mergify.yml
Instead of leaving the generation of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's try this :)
FWIW, I like the new name, but the change has caused me a fair amount of admin work updating branch protection rules in all the repos where we're using sbt-typelevel. Since we have required status checks in place, no PRs can be merged following this change without an admin manually logging in an updating the rules to reflect the new names. Had I realized this change was coming, I would have 👎 solely due to the amount of downstream work involved. (I'm also worried about the change from If anyone is aware of a way to automate the changes to the required status checks, I would be very grateful! |
@bpholt it is probably too late fro that, but an option could be to make this configurable. |
Before
After:
Feedback welcome.
I really dislike this part of the GH UI