Disable the byname-implicit lint on 2.13
#624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an interaction of a scalac bug with shapeless derivation.
-Wmacrosscala/bug#12072Also it is currently blocking the fs2 migration (see armanbilge/fs2#4).
I haven't turned my brain on enough to appreciate the intrinsic value of this lint. Are we losing much by disabling it?
Edit: I guess the PR explains it in scala/scala#8590.
Edit 2: so the primary use of implicit conversions is for syntax. And some Cats ops do take the target as by-name. But applying syntax to a multi-line block? Too weird 😅 I don't think we're missing much.