Added binary versions to module-ignore inputs
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzuehlke
approved these changes
Jul 8, 2023
armanbilge
requested changes
Jul 8, 2023
| Global / noPublishModulesIgnore ++= crossScalaVersions.value.map { v => | ||
| // the binary versions are needed for the modules-ignore in Submit Dependencies | ||
| // it's best to pick them up here instead of guessing in the CI plugin | ||
| s"${thisProjectRef.value.project}_${CrossVersion.binaryScalaVersion(v)}" |
There was a problem hiding this comment.
Unfortunately this is not sufficiently general. You should do something like this.
There was a problem hiding this comment.
btw, to dog-food this we can add some more no-publish modules to sbt-typelevel's own build.
Maybe one enabling the Scala.js plugin, one disabling cross versions (i.e. a java module) and another enabling full cross versions (i.e. a compiler plugin)
There was a problem hiding this comment.
can the crossVersion be assumed to be the same across all the cross-versions?
There was a problem hiding this comment.
Yes, I suppose that has to be the assumption, otherwise everything breaks down 😅
… change to generated CI, illegal configurations are dropped gracefully
armanbilge
reviewed
Jul 9, 2023
no-publish/src/main/scala/org/typelevel/sbt/NoPublishPlugin.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the binary scala suffix to the end of the module names for
Submit Dependencies. The result of the change can be seen in the CI file. Fixes #597