Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for site plugin: adjust for recent changes to tlSiteIsTypelevelProject #562

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

jenshalm
Copy link
Contributor

The docs did not yet reflect recent changes:

  • The setting is no longer Boolean.
  • It is now populated based on the organization setting.

@mergify mergify bot added the docs label Jun 24, 2023
Comment on lines -64 to -69
If the generated documentation is for a Typelevel project, you can optionally enable a set of additional defaults
on top of the generic defaults listed in the previous section:

```scala
tlSiteIsTypelevelProject := true
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be helpful to keep an updated version of this? What I mean is, it seems far more likely an affiliate project would like to know how they can opt-in to the Typelevel theming, rather than an org project wanting to know how it can opt-out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just wasn't sure about the intention here. The Organization value is package-private and the Affiliate is not, yet in the implementation there is no difference between the two. I wasn't exactly sure what these design choices meant, so I did not write about it. 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a section for Affiliate projects based on my somewhat limited understanding of the intentions. Feel free to rephrase or expand if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet in the implementation there is no difference between the two.

We decided in typelevel/governance#34 (comment) to start collecting this information even though we don't know what do with it yet, if anything.

The Organization value is package-private and the Affiliate is not,

Yes, the idea is to discourage users from claiming they are an organization project. We'll see how it works 😀

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@armanbilge armanbilge merged commit 3d19858 into typelevel:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants