-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making mergifyLabelPaths
overridable
#466
Conversation
Hmm, running |
mergify/src/main/scala/org/typelevel/sbt/mergify/MergifyPlugin.scala
Outdated
Show resolved
Hide resolved
I wonder if we ought to have some |
I don't have that much experience with scripted tests if not in g8 templates, but AFAIK, the series/0.5 has some tests I might take inspiration from, I'll check and add them |
Yes, we really ought to have tests in general. I've been lazy to do so, partly because testing generated output can become annoying. See some discussion in #26. For this specific one, we can use a dog-food: override
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to close this one, finally! This was a good exercise in sbt setting evaluation and scoping 🤓
I did it and it might act as a test as you said. For what concerns #26, probably the better thing is to implement them in a separate PR, innit? |
mergifyLabelPaths
overridable
Closes #220.