Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making mergifyLabelPaths overridable #466

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Making mergifyLabelPaths overridable #466

merged 3 commits into from
Feb 28, 2023

Conversation

TonioGela
Copy link
Member

Closes #220.

@mergify mergify bot added the mergify label Feb 10, 2023
@TonioGela
Copy link
Member Author

Hmm, running mergifyGenerate annihilates .mergify.yml, so the pr logic is probably wrong 👉 👈

@bpholt
Copy link
Member

bpholt commented Feb 10, 2023

Hmm, running mergifyGenerate annihilates .mergify.yml, so the pr logic is probably wrong 👉 👈

I wonder if we ought to have some scripted tests for things like this, to show that the generated file is correct in different scenarios. (Not that you have to add that to this PR if you don't want to, just that it might be helpful if you did.)

@TonioGela
Copy link
Member Author

I don't have that much experience with scripted tests if not in g8 templates, but AFAIK, the series/0.5 has some tests I might take inspiration from, I'll check and add them

@armanbilge
Copy link
Member

Yes, we really ought to have tests in general. I've been lazy to do so, partly because testing generated output can become annoying. See some discussion in #26.

For this specific one, we can use a dog-food: override mergifyLabelPaths in build.sbt, just to prove we can. For example you should be able to remove this useless label.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to close this one, finally! This was a good exercise in sbt setting evaluation and scoping 🤓

@TonioGela
Copy link
Member Author

For this specific one, we can use a dog-food: override mergifyLabelPaths in build.sbt, just to prove we can. For example you should be able to remove this useless label.

I did it and it might act as a test as you said. For what concerns #26, probably the better thing is to implement them in a separate PR, innit?

@armanbilge armanbilge merged commit 7a4eb9c into typelevel:series/0.4 Feb 28, 2023
@TonioGela TonioGela deleted the 220 branch February 28, 2023 23:16
@armanbilge armanbilge changed the title Making mergifyLabelPaths overridable Making mergifyLabelPaths overridable Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't disable mergify auto-labeling
3 participants